[FFmpeg-devel] [PATCH]lavf/rtmpcrypt: Add a cast to silence a warning

Carl Eugen Hoyos ceffmpeg at gmail.com
Thu Apr 26 14:42:09 EEST 2018


2018-04-26 13:34 GMT+02:00, Reino Wijnsma <rwijnsma at xs4all.nl>:
> On 22-4-2018 0:52, Reino Wijnsma <rwijnsma at xs4all.nl> wrote:
>> On 16-4-2018 0:19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>> rtmpe_write() exploits knowledge about av_rc4_crypt() internals and
>>> passes the same
>>> pointer as src and dst. I assume this is intentional for performance
>>> reasons, the only
>>> way to silence the resulting warning is a cast afaict.
>>>
>>> Please comment, Carl Eugen
>> $ make libavformat/rtmpcrypt.o
>> CC      libavformat/rtmpcrypt.o
>>
>> No more warning.
> Hello Carl,
>
> Are you going to push this patch as well?

I wanted to request a documentation update
for av_rc4_crypt() first but I realize it is
already there;-)

Will push, Carl Eugen


More information about the ffmpeg-devel mailing list