[FFmpeg-devel] [V2 PATCH 2/4] Add muxing/demuxing of RMHD

Thilo Borgmann thilo.borgmann at mail.de
Mon Apr 23 21:47:00 EEST 2018


Am 23.04.18 um 14:17 schrieb Carl Eugen Hoyos:
> 2018-02-02 3:43 GMT+01:00, Thilo Borgmann <thilo.borgmann at mail.de>:
>> Does not add a new demuxer anymore.
> 
> Good, now please split the patches, the demuxer patches
> look relatively easy to review.
> 
>> For the muxer I'm not sure it should be done - would require more logic to
>> check for valid codec ids for both cases I think (like for AAC audio).
> 
> Not sure I understand: Aren't all the functions identical for both muxers?
> 
> If easily avoidable, no new muxer should be added, Carl Eugen

Have you just answered to the wrong mail and your comments apply to [V3 PATCH 1/3]?

If so, please elaborate your expectations about a better way to split things.

-Thilo


More information about the ffmpeg-devel mailing list