[FFmpeg-devel] [PATCH] configure: fix clang-cl check in the MSVC section

Hendrik Leppkes h.leppkes at gmail.com
Wed Apr 18 17:57:07 EEST 2018


On Wed, Apr 18, 2018 at 4:34 PM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> Without properly grouping the checks, the second test would execute for
> MSVC cl.exe, which results in configure getting stuck since cl.exe -? is
> an interactive paginated help screen, waiting for input.
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 535a59b737..0074f36eba 100755
> --- a/configure
> +++ b/configure
> @@ -4411,7 +4411,7 @@ probe_cc(){
>          _flags_filter=msvc_flags
>          _ld_lib='lib%.a'
>          _ld_path='-libpath:'
> -    elif $_cc -nologo- 2>&1 | grep -q Microsoft || $_cc -v 2>&1 | grep -q clang && $_cc -? > /dev/null 2>&1; then
> +    elif $_cc -nologo- 2>&1 | grep -q Microsoft || { $_cc -v 2>&1 | grep -q clang && $_cc -? > /dev/null 2>&1; } then

There was some concern that some pedantic shells may require a
semicolon after the closing brace even if bash doesn't, so I have
added that locally.

- Hendrik


More information about the ffmpeg-devel mailing list