[FFmpeg-devel] [PATCH] lavc/libopusdec: Allow avcodec_open2 to call .close

Michael Niedermayer michael at niedermayer.cc
Wed Apr 11 01:43:21 EEST 2018


On Tue, Apr 10, 2018 at 02:13:28PM -0700, Matthew Wolenetz wrote:
> 

>  libopusdec.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> a62bece9f45c68d93e138cb021a533fbc242ddc3  0001-lavc-libopusdec-Allow-avcodec_open2-to-call-.close.patch
> From 031e96bd481b7b8d0c11e5353f74fafc69e37f09 Mon Sep 17 00:00:00 2001
> From: Matt Wolenetz <wolenetz at google.com>
> Date: Tue, 10 Apr 2018 13:59:25 -0700
> Subject: [PATCH] lavc/libopusdec: Allow avcodec_open2 to call .close
> 
> If there is a decoder initialization failure detected in avcodec_open2
> after .init is called, allow graceful decoder .close to prevent leaking
> libopus decoder allocations.
> 
> BUG=828526
> ---
>  libavcodec/libopusdec.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Doesnt apply, also the NULL check already exists in git master
FF_CODEC_CAP_INIT_CLEANUP is missing in master though

can you update the patch ?

thx
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180411/b8ae6253/attachment.sig>


More information about the ffmpeg-devel mailing list