[FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding
michael at niedermayer.cc
Wed Apr 11 01:05:25 EEST 2018
On Tue, Apr 10, 2018 at 09:41:05PM +0200, Jerome Martinez wrote:
> On 10/04/2018 12:34, Carl Eugen Hoyos wrote:
> >2018-04-10 12:28 GMT+02:00, Kieran O Leary <kieran.o.leary at gmail.com>:
> >>I just tested this patch non packed to 16-bit gbrp12le DPX from DaVinci
> >Testing is good, apart
> I thought the patch was "technically" OK, as I answered to all change
> requests and there was no additional feedback IIRC.
> > from more brackets
> Not sure I understand, as the only "missing" brackets I see are for the 1
> line code after a "if", and I see that 1 line code has no brackets in other
> parts of the file.
> Anyway, I added more brackets, except for "if (*n_datum) (*n_datum)--;" as I
> copied/pasted it from another part of the file.
> Did I miss something else?
> > (and less comments)
> I thought it would be better for someone willing to add alpha support in the
> future, as the alpha support was tested and "just" rejected for the moment.
> Anyway, I removed the commented code.
> Modified patch attached.
> Note that I personally prefer to use the previous patch (or this patch
> without the additional brackets).
> > it would
> >be better if Jerome sends his public keys to Michael and pushes the patch.
> If it is the only solution for having the patch pushed, I'll do that, even
> if I am not convinced that I deserve for the moment write rights on FFmpeg
> repository (especially because Git and me are not good friends :) ).
what do you mean by "Git and me are not good friends" ?
If git hates you and sometimes does things that you didnt intend at all then
that would be a problem with direct pushes as theres no way to undo.
But maybe i misunderstand.
Also to get git write access, post a patch that adds yourself to the
MAINTAINERs file. When noone objects then ill add your key and apply
the MAINTAINER patch.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: not available
More information about the ffmpeg-devel