[FFmpeg-devel] [PATCH] x86/exrdsp: optimize ff_reorder_pixels_avx2()

James Almer jamrial at gmail.com
Mon Sep 18 04:52:13 EEST 2017


From: Henrik Gramner <henrik at gramner.com>

Tested with "checkasm --test=exrdsp -bench"

Before:
reorder_pixels_c: 5187.8
reorder_pixels_sse2: 377.0
reorder_pixels_avx2: 331.3

After:
reorder_pixels_c: 5181.5
reorder_pixels_sse2: 377.0
reorder_pixels_avx2: 313.8

Signed-off-by: James Almer <jamrial at gmail.com>
---
 libavcodec/x86/exrdsp.asm | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/libavcodec/x86/exrdsp.asm b/libavcodec/x86/exrdsp.asm
index b91a7be20d..06c629e59e 100644
--- a/libavcodec/x86/exrdsp.asm
+++ b/libavcodec/x86/exrdsp.asm
@@ -39,16 +39,15 @@ cglobal reorder_pixels, 3,4,3, dst, src1, size, src2
     neg                              sizeq                ; size = offset for dst, src1, src2
 .loop:
 
-%if cpuflag(avx2)
-    vpermq                              m0, [src1q + sizeq], 0xd8; load first part
-    vpermq                              m1, [src2q + sizeq], 0xd8; load second part
-%else
     mova                                m0, [src1q+sizeq]        ; load first part
     movu                                m1, [src2q+sizeq]        ; load second part
-%endif
     SBUTTERFLY bw, 0, 1, 2                                       ; interleaved
-    mova                 [dstq+2*sizeq   ], m0                   ; copy to dst
-    mova             [dstq+2*sizeq+mmsize], m1
+    mova                 [dstq+2*sizeq   ], xm0                  ; copy to dst
+    mova                 [dstq+2*sizeq+16], xm1
+%if cpuflag(avx2)
+    vperm2i128                          m0, m0, m1, q0301
+    mova                 [dstq+2*sizeq+32], m0
+%endif
     add     sizeq, mmsize
     jl .loop
     RET
-- 
2.14.1



More information about the ffmpeg-devel mailing list