[FFmpeg-devel] [PATCH V6] lavfi/scale_vaapi: add denoise/sharpness support.

Mark Thompson sw at jkqxz.net
Sat Sep 9 13:30:36 EEST 2017


On 04/08/17 08:25, Jun Zhao wrote:
> V6 : - Re-work with current scale_vaapi and double check i965 have fix the sharpness issue.
>        https://bugs.freedesktop.org/show_bug.cgi?id=96988
> v5 : - fix the commit message as review(Mark Thompson and Moritz Barsnick)
>      - change the magic filter numbers 8 with VAProcFilterCount
>      - check multiple filters because multiple filters aren't supported in
>        the driver now
> v4 : - fix sharpless typo(sharpless -> sharpness)
>      - when don't support denoise/sharpness, report the error and return
>      - fix denoise/sharpness params buffer leak in error handle
> v3 : fix sharpless mapping issue
> v2 : fix filter support flag check logic issue
> 

I still think this approach splicing it into the scale filter is an ugly hack (as the previous time it was submitted), and that the standalone filter (as I wrote a proof-of-concept for last time) would be more sensible.

(Though if everyone else really thinks that this is a good idea then I won't protest that hard.)

- Mark


More information about the ffmpeg-devel mailing list