[FFmpeg-devel] [PATCH 2/2] avcodec/pthread_slice: add main function support for avpriv_slicethread_create()

Michael Niedermayer michael at niedermayer.cc
Thu Sep 7 23:40:22 EEST 2017


On Fri, Sep 08, 2017 at 12:55:29AM +0700, Ilia Valiakhmetov wrote:
> ---
>  libavcodec/internal.h      |  4 ++++
>  libavcodec/pthread_slice.c | 33 ++++++++++++++-------------------
>  libavcodec/thread.h        |  1 +
>  libavutil/slicethread.h    | 18 ++++++++++++++++++
>  4 files changed, 37 insertions(+), 19 deletions(-)

applying only patch 1 fails to build

libavcodec/vp9.c: In function ‘thread_execute3’:
libavcodec/vp9.c:94:5: error: unknown type name ‘SliceThreadContext’
     SliceThreadContext *c = avctx->internal->thread_ctx;
     ^
libavcodec/vp9.c:95:6: error: request for member ‘func2’ in something not a structure or union
     c->func2 = func;
      ^
libavcodec/vp9.c:96:6: error: request for member ‘m_func’ in something not a structure or union
     c->m_func = m_func;
      ^
libavcodec/vp9.c:97:5: error: implicit declaration of function ‘ff_thread_execute’ [-Werror=implicit-function-declaration]
     return ff_thread_execute(avctx, NULL, arg, ret, job_count, 0);
     ^
libavcodec/vp9.c: At top level:
libavcodec/vp9.c:1790:22: error: ‘FF_CODEC_CAP_SLICE_THREAD_HAS_MF’ undeclared here (not in a function)
     .caps_internal         = FF_CODEC_CAP_SLICE_THREAD_HAS_MF,
                      ^


applying both patches fails to build on mingw64

In file included from src/libavutil/slicethread.c:20:0:
src/libavutil/slicethread.h:38:5: error: unknown type name ‘pthread_cond_t’
     pthread_cond_t *progress_cond;
     ^
src/libavutil/slicethread.h:39:5: error: unknown type name ‘pthread_mutex_t’
     pthread_mutex_t *progress_mutex;
     ^
make: *** [libavutil/slicethread.o] Error 1
make: *** Waiting for unfinished jobs....


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who would give up essential Liberty, to purchase a little
temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170907/cbc57914/attachment.sig>


More information about the ffmpeg-devel mailing list