[FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

Kieran Kunhya kierank at obe.tv
Mon Sep 4 03:57:32 EEST 2017


On Mon, 4 Sep 2017 at 00:56 Michael Niedermayer <michael at niedermayer.cc>
wrote:

> We have always printed error messages for the case that an error
> occured.
> Its unprofessional to fail decoding a file but not provide any
> hint as to why a failure occured.
>
> If we remove all error messages and just print a generic "failed
> decoding header" or "failed to decode frame"
> We would leave users wondering about each error and we would no longer
> have differentiated bug reports.
> There would be one very huge bug report about
> "Error while decoding stream #0:0: Invalid data found when processing
> input"
> Because thats all detail the user can get if the message is not in the
> binary.
> That bug report then would be marked invalid of course and would help
> neither users nor developers.
>

We ask users to report bugs with "--loglevel 99" so this is irrelevant if
it's a DEBUG.


> Iam not sure why error messages are since about a year or so
> considered controversial by some developers but not before
>

In my case I get a lot of reports from users about ffmpeg spamming logs
with obscure warnings.
This happens on legal files as per my "SPS/PPS truncation" patch which
scares them into thinking the file is broken.

The same goes with spamming logs when there is some data corruption with
warnings which are very obscure.

Regards,
Kieran Kunhya


More information about the ffmpeg-devel mailing list