[FFmpeg-devel] [PATCH v3] avformat/dash: move reused API to common file and header file

Steven Liu lingjiujianke at gmail.com
Fri Sep 1 05:22:48 EEST 2017


2017-09-01 0:21 GMT+08:00 wm4 <nfxjfg at googlemail.com>:
> On Thu, 31 Aug 2017 22:56:53 +0800
> Steven Liu <lq at chinaffmpeg.org> wrote:
>
>> move from dashenc, move DASHTmplId and dash_fill_tmpl_params to
>> dash.c, they will be used by dash demuxer and dash muxer.
>>
>> v2 fixed:
>> 1. rename common file from dashcomm.* to dash.*
>> Suggested-by: Hendrik Leppkes <h.leppkes at gmail.com>
>>
>> v3 fixed:
>> 1. rename header file pre defined
>> 2. add ff_ prefix for the internal API
>> Suggested-by: James Almer <jamrial at gmail.com>
>>
>> Suggested-by: Timo Rothenpieler <timo at rothenpieler.org>
>> Signed-off-by: Steven Liu <lq at onvideo.cn>
>> ---
>>  libavformat/Makefile  |   2 +-
>>  libavformat/dash.c    | 136 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  libavformat/dash.h    |  39 +++++++++++++++
>>  libavformat/dashenc.c | 130 ++---------------------------------------------
>>  4 files changed, 180 insertions(+), 127 deletions(-)
>>  create mode 100644 libavformat/dash.c
>>  create mode 100644 libavformat/dash.h
>>
>
> LGTM, assuming FATE passes, and you didn't make any semantic changes.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Pushed.

Thanks


More information about the ffmpeg-devel mailing list