[FFmpeg-devel] [PATCH] avfilter: initial macroblock types export and visualization

[Michael Niedermayer]

On Fri, Oct 27, 2017 at 10:03:54PM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavcodec/mpegvideo.c     |  10 +++++
>  libavfilter/vf_codecview.c | 105 +++++++++++++++++++++++++++++++++++++++++++++
>  libavutil/frame.h          |   4 ++
>  3 files changed, 119 insertions(+)

First, thanks for working on this.


[...]

> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index fef558ea2f..8481dc080b 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -141,6 +141,10 @@ enum AVFrameSideDataType {
>       * metadata key entry "name".
>       */
>      AV_FRAME_DATA_ICC_PROFILE,
> +    /**
> +     * Macroblock types exported by some codecs.
> +     */
> +    AV_FRAME_DATA_MACROBLOCK_TYPES,
>  };
>  

This makes the internal data of the decoder part of the ABI and API of
libavcodec and libavfilter
and its undocumented

do people prefer to make the internal data part of the ABI, document
it and ensure it does not change till the next bump
or design a new interface, document it and convert to it?
or is there some other option iam missing ?

these ABI issues btw are why i said i dont have the time for doing the
move.

also it seems the patch breaks fate-mov-zombie

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171028/cdad972b/attachment.sig>