[FFmpeg-devel] [PATCH v2] avformat/wavenc: skip writing incorrect peak-of-peaks position value

Michael Niedermayer michael at niedermayer.cc
Wed Oct 25 20:55:52 EEST 2017


On Tue, Oct 24, 2017 at 11:47:21AM +0200, Tobias Rapp wrote:
> According to EBU tech 3285 supplement 3 the dwPosPeakOfPeaks field
> should contain the absolute position to the maximum audio sample value,
> but the current implementation writes the relative peak frame index
> instead.
> 
> Fix the issue by writing the "unknown" value (-1) for now until the
> feature is implemented correctly.
> 
> Previous version reviewed-by: Peter Bubestinger <p.bubestinger at av-rd.com>
> Signed-off-by: Tobias Rapp <t.rapp at noa-archive.com>
> ---
> v2:
>  - added version micro bump
>  - more code clean-up
> 
>  libavformat/version.h        |  2 +-
>  libavformat/wavenc.c         | 11 +----------
>  tests/ref/lavf/wav_peak      |  2 +-
>  tests/ref/lavf/wav_peak_only |  2 +-
>  4 files changed, 4 insertions(+), 13 deletions(-)

will apply, thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171025/73088b58/attachment.sig>


More information about the ffmpeg-devel mailing list