[FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

Carl Eugen Hoyos ceffmpeg at gmail.com
Tue Oct 24 02:56:21 EEST 2017

2017-10-24 1:43 GMT+02:00 Niki Bowe <nbowe-at-google.com at ffmpeg.org>:
> On Thu, Oct 19, 2017 at 3:39 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com>
> wrote:

>> Does the patch have a measurable speed impact?
> Is there a standard set of benchmarks I can run?
> For typical videos the speed impact is small, due to NALU fitting in cache,
> but for videos with many large NALUs there can be some slowdown.

(5% overall slowdown would make every patch unacceptable
but I doubt this is the case.)

Use the TIMER makros from libavutil/timer.h, put them around all
calls to ff_h2645_extract_rbsp().

Carl Eugen

More information about the ffmpeg-devel mailing list