[FFmpeg-devel] [PATCH] libavformat: not treat 0 as EOF

[Hendrik Leppkes]

On Mon, Oct 23, 2017 at 3:22 PM, James Almer <jamrial at gmail.com> wrote:
> On 10/23/2017 5:25 AM, Daniel Kučera wrote:
>> 2017-10-21 13:36 GMT+02:00 Jan Ekstrom <jeebjp at gmail.com>:
>>>
>>> This seems to have broken seeking and files ending. FLAC was
>>> experienced yesterday but it seems like it's more general. This was
>>> reported on the mpv users' channel by sfan5, but I feel like this
>>> might be more general than related to just mpv. At first this was
>>> thought to be limited to HTTP, but later was found out to be
>>> applicable to local files as well.
>>>
>>
>>
>> Hi Jan,
>>
>> please post a test case, ideally as an issue into trac.
>
> https://trac.ffmpeg.org/ticket/6767

This appears to be an API break, since those avio callbacks are
basically public API. Previously ret 0 for EOF was perfectly valid
(just like many OS I/O functions also act), and now it needs special
casing. I had to update my own code as well for this breakage.
We should fix the API break somehow.

- Hendrik