[FFmpeg-devel] [PATCH] avcodec/version: Postpone FF_API_DEBUG_MV

[James Almer]

On 10/22/2017 8:26 AM, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Oct 21, 2017 at 9:23 PM, Michael Niedermayer <michael at niedermayer.cc
>> wrote:
> 
>> On Sat, Oct 21, 2017 at 08:52:26PM -0400, Ronald S. Bultje wrote:
>>> Hi,
>>>
>>> On Sat, Oct 21, 2017 at 8:37 PM, Michael Niedermayer
>> <michael at niedermayer.cc
>>>> wrote:
>>>
>>>> This is different from FF_API_VISMV which is supported through
>> codecview.
>>>>
>>>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>>>> ---
>>>>  libavcodec/version.h | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/libavcodec/version.h b/libavcodec/version.h
>>>> index 8584bb7006..25696690d7 100644
>>>> --- a/libavcodec/version.h
>>>> +++ b/libavcodec/version.h
>>>> @@ -79,7 +79,7 @@
>>>>  #define FF_API_SET_DIMENSIONS    (LIBAVCODEC_VERSION_MAJOR < 58)
>>>>  #endif
>>>>  #ifndef FF_API_DEBUG_MV
>>>> -#define FF_API_DEBUG_MV          (LIBAVCODEC_VERSION_MAJOR < 58)
>>>> +#define FF_API_DEBUG_MV          (LIBAVCODEC_VERSION_MAJOR < 59)
>>>>  #endif
>>>>
>>>
>>> Can you give an explanation for why this should be delayed? (It's missing
>>> in the commit message, and this is hard to evaluate without a
>>> justification/explanation.)
>>
>> It was not agreed on ffmpeg-devel to remove this feature.
>>
>> Its used for example by me occasionally to analyze videos in bug
>> reports for debuging them.
>>
>> There is no replacement or alternative iam aware of
>>
> 
> The replacement will never be written if:
> a) nobody cares; AND
> b) we keep delaying the removal
> 
> I'm considering veto'ing this patch.

Personally I'm with Clement in this. The deprecation was poorly handled,
and the feature currently has no replacement. Michael uses it for
debugging, so removing it does not seem productive.

But, also agreeing with Clement, this should absolutely be ported to the
codecview filter before the next bump, or it will be removed.