[FFmpeg-devel] [PATCH] libavformat: not treat 0 as EOF

[Jan Ekstrom]

On Tue, Oct 17, 2017 at 11:29 AM, Daniel Kucera <daniel.kucera at gmail.com> wrote:
> transfer_func variable passed to retry_transfer_wrapper
> are h->prot->url_read and h->prot->url_write functions.
> These need to return EOF or other error properly.
> In case of returning >= 0, url_read/url_write is retried
> until error is returned.

This seems to have broken seeking and files ending. FLAC was
experienced yesterday but it seems like it's more general. This was
reported on the mpv users' channel by sfan5, but I feel like this
might be more general than related to just mpv. At first this was
thought to be limited to HTTP, but later was found out to be
applicable to local files as well.

Quote:
< wm4> reproduction is "play anything with lavf"
< JEEB> oh really? and seek?
< sfan5> yes
< wm4> no, seek close to end of file and see if it ends correctly. if
it freezes it's the bug
< sfan5> sounds like two different bugs
< sfan5> bug 1: files don't end correctly
< sfan5> bug 2: seeking somewhere never finishes and spins the cpu
< sfan5> 2 is what i was experiencing yesterday


Best regards,
Jan