[FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

[Bjorn Roche]

On Tue, Oct 17, 2017 at 5:27 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com>
wrote:

> 2017-10-17 3:16 GMT+02:00 Carl Eugen Hoyos <ceffmpeg at gmail.com>:
> > 2017-10-10 23:41 GMT+02:00 Bjorn Roche <bjorn at giphy.com>:
> >
> >> +    { "trans_threshold", "set the threshold for alpha values avoce
> which they are considered completely opaque", OFFSET(trans_thresh),
> AV_OPT_TYPE_INT, {.i64=128}, 0, 255, },
>

Looks like I somehow spelled "above" "avoce".


> > I wonder if "threshold" is enough.
> >
> > No more comments from me, thank you!
>
> Remaining comment is:
> The paletteuse filter does not work correctly on big-endian
> (my guess is the code makes wrong assumptions about the
> palette colour-space), I don't think this should delay this
> patch though.


Is this due to the patch, or was this a problem prior to the patch as well?
If it's due to the patch, I can try to gain access to a big-endian machine
and see if I can fix it.

bjorn

-- 


Bjorn Roche

Sr. Video Pipeline Engineer

bjorn at giphy.com