[FFmpeg-devel] [PATCH 1/3] libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

Nicolas George george at nsup.org
Sun Oct 15 21:26:25 EEST 2017


Le duodi 22 vendémiaire, an CCXXVI, Daniel Kucera a écrit :
> transfer_func variable passed to retry_transfer_wrapper
> are h->prot->url_read and h->prot->url_write functions.
> These need to return EOF or other error properly.
> In case of returning >= 0, url_read/url_write is retried
> until error is returned.
> 
> Signed-off-by: Daniel Kucera <daniel.kucera at gmail.com>
> ---
>  libavformat/avio.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

I think the changes in this series are mostly correct, but the fact they
cause failure if they are applied separately is a little worrying. There
is something subtly wrong going on here.

I think there is another instance of the problem hidden somewhere that
is causing more complication. I have been trying to find it, but not
yet. Still on it when I have time.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171015/173fb860/attachment.sig>


More information about the ffmpeg-devel mailing list