[FFmpeg-devel] [FFmpeg-cvslog] Merge commit '7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63'

[Reino Wijnsma]

On 14-10-2017 1:32, James Almer <jamrial at gmail.com> wrote:
> On 10/13/2017 6:30 PM, Reino Wijnsma wrote:
>> _Libilbc_
>> On 13-10-2017 20:09, James Almer <jamrial at gmail.com> wrote:
>>> With this, the check will include the needed pthreads ldflags when
>>> pkg-config is invoked with the --static flag.
>> My 'libilbc.pc' doesn't include -lpthread at all. Adding it here
>> manually works for me.
> It doesn't? That's weird, seeing "Libs.private: @PTHREAD_LIBS@" is
> listed in the source package.
I've seen it too in 'libilbc.pc.in', but still the final 'libilbc.pc'
doesn't have it.

On 14-10-2017 1:32, James Almer <jamrial at gmail.com> wrote:
> On 10/13/2017 6:30 PM, Reino Wijnsma wrote:
>> And this works. No more errors during ./configure, but then...
>> [...]
>> CC      fftools/ffmpeg_cuvid.o
>> LD      ffmpeg_g.exe
>> /cygdrive/[...]/lib/libgnutls.a(sha256-ssse3-x86.o): warning: common of
>> `_gnutls_x86_cpuid_s' overridden by definition
>> /cygdrive/[...]/lib/libgnutls.a(x86-common.o): warning: defined here
>> /cygdrive/[...]/lib/libmpg123.a(compat.o):compat.c:(.text+0xcb):
>> undefined reference to `_imp__PathIsRelativeW at 4'
>> /cygdrive/[...]/lib/libmpg123.a(compat.o):compat.c:(.text+0x224):
>> undefined reference to `_imp__PathIsUNCW at 4'
>> /cygdrive/[...]/lib/libmpg123.a(compat.o):compat.c:(.text+0x4e9):
>> undefined reference to `_imp__PathIsRelativeW at 4'
>> /cygdrive/[...]/lib/libmpg123.a(compat.o):compat.c:(.text+0x670):
>> undefined reference to `_imp__PathIsUNCW at 4'
>> /cygdrive/[...]/lib/libmpg123.a(compat.o):compat.c:(.text+0xd4b):
>> undefined reference to `_imp__PathCombineW at 12'
>> /cygdrive/[...]/lib/libmpg123.a(compat.o):compat.c:(.text+0xf1b):
>> undefined reference to `_imp__PathIsRelativeW at 4'
>> /cygdrive/[...]/lib/libmpg123.a(compat.o):compat.c:(.text+0x10c4):
>> undefined reference to `_imp__PathIsUNCW at 4'
> These are from -lshlwapi.
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0xe66):
>> undefined reference to `_imp__CertGetCertificateContextProperty at 16'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x1652):
>> undefined reference to `_imp__CertOpenSystemStoreA at 8'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x168e):
>> undefined reference to `_imp__CertFindCertificateInStore at 24'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x16b1):
>> undefined reference to `_imp__CertGetCertificateContextProperty at 16'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x192d):
>> undefined reference to `_imp__CertFreeCertificateContext at 4'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x193f):
>> undefined reference to `_imp__CertCloseStore at 8'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x2167):
>> undefined reference to `_imp__CertOpenSystemStoreA at 8'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x21a3):
>> undefined reference to `_imp__CertFindCertificateInStore at 24'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x21f0):
>> undefined reference to `_imp__CertFreeCertificateContext at 4'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x221d):
>> undefined reference to `_imp__CertCloseStore at 8'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x23ad):
>> undefined reference to `_imp__CertCloseStore at 8'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x249f):
>> undefined reference to `_imp__CertOpenSystemStoreA at 8'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x255b):
>> undefined reference to `_imp__CertEnumCertificatesInStore at 8'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x26db):
>> undefined reference to `_imp__CertOpenSystemStoreA at 8'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x2735):
>> undefined reference to `_imp__CertFindCertificateInStore at 24'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x277b):
>> undefined reference to `_imp__CertGetCertificateContextProperty at 16'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x27cd):
>> undefined reference to `_imp__CertCloseStore at 8'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x286f):
>> undefined reference to `_imp__CertDeleteCertificateFromStore at 4'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x2ab5):
>> undefined reference to `_imp__CertCloseStore at 8'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x2d70):
>> undefined reference to `_imp__PFXImportCertStore at 12'
>> /cygdrive/[...]/lib/libgnutls.a(keys-win.o):keys-win.c:(.text+0x2e7f):
>> undefined reference to `_imp__CertFindCertificateInStore at 24'
>> /cygdrive/[...]/lib/libgnutls.a(certs.o):certs.c:(.text+0xe0): undefined
>> reference to `_imp__CertOpenSystemStoreA at 8'
>> /cygdrive/[...]/lib/libgnutls.a(certs.o):certs.c:(.text+0xf5): undefined
>> reference to `_imp__CertEnumCertificatesInStore at 8'
>> /cygdrive/[...]/lib/libgnutls.a(certs.o):certs.c:(.text+0x1fb):
>> undefined reference to `_imp__CertCloseStore at 8'
>> /cygdrive/[...]/lib/libgnutls.a(certs.o):certs.c:(.text+0x230):
>> undefined reference to `_imp__CertOpenSystemStoreA at 8'
> And these from -lcrypt32
> You had those two as custom extra-ldflags before the commit that
> introduced all these issues, or had to start doing it after it?
I forgot to mention I also appended "-lcrypt32" to the gnutls-line:

enabled gnutls            && require_pkg_config gnutls gnutls
gnutls/gnutls.h gnutls_global_init -lcrypt32

It fixes "undefined reference to `_imp__Cert[...]'" and "ERROR: gnutls
not found using pkg-config" (Windows only issue?) during ./configure,
and it now seems _only_ during ./configure. ./configure --enable-gnutls
--extra-libs=-lcrypt32 is still needed for making 'ffmpeg.exe'. And the
same goes for -lshlwapi.

I've applied your "[FFmpeg-devel] [PATCH] configure: add pthreads
ldflags globally" and "[FFmpeg-devel] [PATCH] build: add global
extralibs to pkg-config file generation" patch and I've successfully
compiled a FFmpeg build with ./configure --enable-gnutls
--extra-libs=-lcrypt32 --enable-libcaca --extra-cflags=-DCACA_STATIC
--enable-libopenmpt --extra-libs=-lshlwapi --enable-libtwolame
--extra-cflags=-DLIBTWOLAME_STATIC.

-- Reino