[FFmpeg-devel] [PATCH 2/2] avcodec/dvbsubdec: Split best score computation out of loop in compute_default_clut()

[Michael Niedermayer]

On Sun, Oct 01, 2017 at 06:26:53PM +0200, Clément Bœsch wrote:
> On Sun, Oct 01, 2017 at 06:10:36PM +0200, Michael Niedermayer wrote:
> > 3% faster
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/dvbsubdec.c | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c
> > index 6a40f2376f..e60bf41936 100644
> > --- a/libavcodec/dvbsubdec.c
> > +++ b/libavcodec/dvbsubdec.c
> > @@ -681,14 +681,17 @@ static void compute_default_clut(AVSubtitleRect *rect, int w, int h)
> >                  int l_r = x+1<w ? L(+1, 0) : 1;
> >                  int l_t = y     ? L(0, -1) : 1;
> >                  int l_b = y+1<h ? L(0, +1) : 1;
> > -                int score;
> >                  if (l_m)
> >                      continue;
> >                  scoretab[v] += l_l + l_r + l_t + l_b;
> > -                score = 1024LL*scoretab[v] / counttab[v];
> > +            }
> > +        }
> > +        for (x = 0; x < 256; x++) {
> > +            if (scoretab[x]) {
> > +                int score = 1024LL*scoretab[x] / counttab[x];
> >                  if (score > bestscore) {
> >                      bestscore = score;
> > -                    bestv = v;
> > +                    bestv = x;
> >                  }
> >              }
> >          }
> 
> OK

applied

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171014/9321022d/attachment.sig>