[FFmpeg-devel] [FFmpeg-cvslog] Merge commit '7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63'

[James Almer]

On 10/12/2017 7:19 PM, Carl Eugen Hoyos wrote:
> 2017-10-13 0:12 GMT+02:00 James Almer <jamrial at gmail.com>:
>> On 10/12/2017 6:50 PM, Carl Eugen Hoyos wrote:
>>> 2017-10-12 23:45 GMT+02:00 James Almer <jamrial at gmail.com>:
>>>> On 10/12/2017 6:41 PM, Michael Niedermayer wrote:
>>>
>>>>> also video4linux is gone
>>>>>
>>>>> ./configure
>>>>> config.h:#define CONFIG_V4L2_INDEV 0
>>>>>
>>>>> and with a branch with all that reverted:
>>>>> ./configure
>>>>> config.h:#define CONFIG_V4L2_INDEV 1
>>>>
>>>> v4l2 is not autodetected.
>>>
>>> I tested several old versions, for the last 10 years,
>>> v4l2 indev was auto-detected.
>>>
>>> From tests with really old versions I know that
>>> video4linux (1) was always auto-detected (or
>>> auto-enabled).
>>>
>>> Carl Eugen
>>
>> configure has the line
>>
>> --enable-libv4l2         enable libv4l2/v4l-utils [no]
>>
>> And before the commit i mentioned, it had the line
>>
>> libv4l2_indev_deps="libv4l2"
>>
>> If you check alldevices.c, there's no indev called "libv4l2_indev", only
>> one called "v4l2_indev".
>> Since the latter had no dependency on libv4l2, it was of course always
>> enabled by default. I changed that in 734ed38931 (see ticket #6729,
>> where doing that fixed a failure).
>>
>> So that indev being auto-enabled might have been a mistake all this time.
> 
> Sorry, what are you talking about?
> v4l2 was added in 2006 and auto-detected ever since.
> Before 2006, there was already v4l (1) which was
> auto-enabled since forever afair.
> 
> There is a helper library called libv4l2 that - luckily -
> is not auto-detected and shouldn't be.

So v4l2_indev should not depend on libv4l2? Any idea why doing that
fixed ticket #6729?

Also, i don't get then why was there a libv4l2_indev listed in configure.

> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>