[FFmpeg-devel] [PATCH v2] Fix visual glitch with XvMC, caused by wrong idct permutation.

[Ivan Kalvachev]

On 10/9/17, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Mon, Oct 09, 2017 at 09:02:38AM -0400, Ronald S. Bultje wrote:
>> Hi,
>>
>> On Mon, Oct 9, 2017 at 6:46 AM, Ivan Kalvachev <ikalvachev at gmail.com>
>> wrote:
>>
>> > On 10/9/17, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> > > On Sun, Oct 8, 2017 at 6:52 PM, Ivan Kalvachev <ikalvachev at gmail.com>
>> > wrote:
>> > > [..]
>> > >
>> > > Indentation is off in the second hunk, can you fix that?
>> >
>> > You want it 4 spaces to the right

Done.

>>
>> Yes, please.
>>
>> BTW, I think it would be better to use "127" number.
>> >
>>
>> I don't really mind either way. The number 128 suggests it may have been
>> intended as a bitmask. Michael is probably better positioned to comment
>> on
>> this.
>
> I don't really remember but i think 128 was chosen for ABI
> compatibility with additions to it from libav. So it should no longer
> matter what values are used on additions

Then I'm using the next free number "24".

Please, commit when you think it is appropriate.

Best Regards
   Ivan Kalvachev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-visual-glitch-with-XvMC-caused-by-wrong-idct-per.v2.patch
Type: text/x-patch
Size: 2355 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171010/4a86f609/attachment.bin>