[FFmpeg-devel] [FFmpeg-cvslog] configure: Disable -Wbool-operation.

[Carl Eugen Hoyos]

2017-10-09 2:02 GMT+02:00 James Almer <jamrial at gmail.com>:
> On 10/8/2017 9:02 PM, Mark Thompson wrote:
>> On 09/10/17 00:34, Carl Eugen Hoyos wrote:
>>> 2017-10-09 1:26 GMT+02:00 Mark Thompson <sw at jkqxz.net>:
>>>> On 08/10/17 22:08, Carl Eugen Hoyos wrote:
>>>>> ffmpeg | branch: master | Carl Eugen Hoyos <ceffmpeg at gmail.com> | Sun Oct  8 23:08:09 2017 +0200| [c2d155e11ee5ec732d471982f2dee43703bcd5a7] | committer: Carl Eugen Hoyos
>>>>>
>>>>> configure: Disable -Wbool-operation.
>>>>>
>>>>> Requested-by: Ronald and Derek
>>>>>
>>>>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c2d155e11ee5ec732d471982f2dee43703bcd5a7
>>>>> ---
>>>>>
>>>>>  configure | 1 +
>>>>>  1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/configure b/configure
>>>>> index 77c9a18c3c..d5e96e95e1 100755
>>>>> --- a/configure
>>>>> +++ b/configure
>>>>> @@ -6291,6 +6291,7 @@ check_cflags -Wmissing-prototypes
>>>>>  check_cflags -Wno-pointer-to-int-cast
>>>>>  check_cflags -Wstrict-prototypes
>>>>>  check_cflags -Wempty-body
>>>>> +check_cflags -Wno-bool-operation
>>>>>
>>>>>  if enabled extra_warnings; then
>>>>>      check_cflags -Wcast-qual
>>>>>
>>>>
>>>> Following this I am now getting a lot of:
>>>>
>>>> src/libavformat/dump.c: At top level:
>>>> cc1: warning: unrecognized command line option ‘-Wno-bool-operation’
>>>
>>> Please revert, sorry for the mess!
>>
>> Ok, reverted for now.
>>
>> I do agree with the intent of the patch, though, so we should fix this.  It looks like it will affect all future warnings with GCC, so it probably needs a new function in configure to do the warning test in a different way somehow.
>>
>> Thanks,
>>
>> - Mark
>
> This test should probably use check_disable_warning() instead of
> check_cflags().

Done.

Thank you both, Carl Eugen