[FFmpeg-devel] [PATCH] ffmpeg: always init output stream before reaping filters

Paul B Mahol onemda at gmail.com
Sat Oct 7 11:12:31 EEST 2017


On 10/6/17, Marton Balint <cus at passwd.hu> wrote:
>
>
> On Wed, 4 Oct 2017, Marton Balint wrote:
>
>> Otherwise the frame size of the codec is not set in the buffersink.
>>
>> Fixes ticket #6603 and the following simpler case:
>>
>> ffmpeg -c aac -filter_complex "sine=d=0.1,asetnsamples=1025" out.aac
>>
>> Signed-off-by: Marton Balint <cus at passwd.hu>
>
> As this patch fixes a regression, this should also be in 3.4, so ping for
> this.
>
> Thanks,
> Marton
>
>> ---
>> fftools/ffmpeg.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
>> index 1d248bc269..5be8788ea8 100644
>> --- a/fftools/ffmpeg.c
>> +++ b/fftools/ffmpeg.c
>> @@ -4528,6 +4528,15 @@ static int transcode_step(void)
>>     }
>>
>>     if (ost->filter && ost->filter->graph->graph) {
>> +        if (!ost->initialized) {
>> +            char error[1024] = {0};
>> +            ret = init_output_stream(ost, error, sizeof(error));
>> +            if (ret < 0) {
>> +                av_log(NULL, AV_LOG_ERROR, "Error initializing output
>> stream %d:%d -- %s\n",
>> +                       ost->file_index, ost->index, error);
>> +                exit_program(1);
>> +            }
>> +        }
>>         if ((ret = transcode_from_filter(ost->filter->graph, &ist)) < 0)
>>             return ret;
>>         if (!ist)
>> --
>> 2.13.5
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

lgtm


More information about the ffmpeg-devel mailing list