[FFmpeg-devel] [PATCH]lavc/h264:Only check x264_build if it was set

Michael Niedermayer michael at niedermayer.cc
Sat Oct 7 00:21:56 EEST 2017

On Fri, Oct 06, 2017 at 08:19:43PM +0200, Carl Eugen Hoyos wrote:
> 2017-10-06 18:54 GMT+02:00 Henrik Gramner <henrik at gramner.com>:
> > On Thu, Oct 5, 2017 at 8:31 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> >> Hi!
> >>
> >> Attached patch fixes ticket #6717.
> >>
> >> Please comment, Carl Eugen
> >
> > Signed numbers are converted to unsigned when compared to unsigned
> > numbers which means -1 becomes UINT_MAX so this patch shouldn't
> > actually change anything.
> Thank you both for pointing this out!
> > #6717 is probably unfixable without breaking something else.
> I believe an option to force the work-around should at least be
> discussed.

If theres need to add an option then a value in workaround_bugs
can be added. This field is used in other decoders for the same
Or some option to set x264_build could be added. This may be better

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171006/318ef05b/attachment.sig>

More information about the ffmpeg-devel mailing list