[FFmpeg-devel] [PATCH 3/7] Removing some debugging

Carl Eugen Hoyos ceffmpeg at gmail.com
Tue Oct 3 11:02:49 EEST 2017

2017-10-03 1:52 GMT+02:00 Bjorn Roche <bjorn at giphy.com>:

> Attached is a patch for paletteuse only.

I tested the following with and without your patch:
$ ffmpeg -i fate-suite/lena.pnm -vf palettegen pal.png
$ ffmpeg -i fate-suite/lena.pnm -i pal.png -lavfi paletteuse out.png

out.png changes with your patch: Is that intended?
The input frame contains no transparency.

Your patch still contains printfs that should be removed
(change them to av_log(DEBUG) if you think they are
useful) and a new warning is shown at compilation:
libavfilter/vf_paletteuse.c: In function ‘colormap_nearest_recursive’:
libavfilter/vf_paletteuse.c:242:5: warning: ISO C90 forbids mixed
declarations and code

Please fix the style: Space after "if", no space after "if ("

Thank you, Carl Eugen

More information about the ffmpeg-devel mailing list