[FFmpeg-devel] [PATCH] avfilter: add fillborders filter

[Paul B Mahol]

On 11/30/17, Moritz Barsnick <barsnick at gmx.net> wrote:
> On Wed, Nov 29, 2017 at 20:16:16 +0100, Paul B Mahol wrote:
>> + at item mode
>> +Set fill mode.
>> +
>> +It accepts the following values:
>> + at table @samp
>> + at item smear
>> +fill pixels using outermost pixels
>> +
>> + at item mirror
>> +fill pixels using mirroring
>> +
>> + at item fixed
>> +fill pixels with constant value
>> + at end table
>
> "Default value is @code{smear}."

Fixed.

>
>> +Set color for pixels in fixed mode. Defauls is @var{black}.
> Typo:                                  ^ Default

Fixed.

>
>
>> +    s->yuv_color[Y] = RGB_TO_Y_CCIR(s->rgba_color[R], s->rgba_color[G],
>> s->rgba_color[B]);
>> +    s->yuv_color[U] = RGB_TO_U_CCIR(s->rgba_color[R], s->rgba_color[G],
>> s->rgba_color[B], 0);
>> +    s->yuv_color[V] = RGB_TO_V_CCIR(s->rgba_color[R], s->rgba_color[G],
>> s->rgba_color[B], 0);
>> +    s->yuv_color[A] = s->rgba_color[A];
>
> This RGB to YUV calculation could go into the else block below, since
> it's only required/used there, right?:

It could but it does not hurt to have it where it is.

>
>> +    if (desc->flags & AV_PIX_FMT_FLAG_RGB) {
>> +        memcpy(s->fill, s->rgba_color, sizeof(s->rgba_color));
>> +    } else {
>> +        memcpy(s->fill, s->yuv_color, sizeof(s->yuv_color));
>> +    }
>
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>