[FFmpeg-devel] [PATCH] examples/hw_decode: Use hw-config information to find pixfmt

[Carl Eugen Hoyos]

2017-11-29 13:41 GMT+01:00 Timo Rothenpieler <timo at rothenpieler.org>:
> Am 29.11.2017 um 13:22 schrieb Moritz Barsnick:
>>
>> On Wed, Nov 29, 2017 at 00:34:03 +0000, Mark Thompson wrote:
>>>
>>> +    if (type == AV_HWDEVICE_TYPE_NONE) {
>>> +        fprintf(stderr, "Device type %s is not supported.\n", argv[1]);
>>> +        fprintf(stderr, "Available device types:");
>>> +        type = AV_HWDEVICE_TYPE_NONE;
>>> +        while((type = av_hwdevice_iterate_types(type)) !=
>>> AV_HWDEVICE_TYPE_NONE)
>>> +            fprintf(stderr, " %s", av_hwdevice_get_type_name(type));
>>
>>
>> I see what you're trying to do with "type = AV_HWDEVICE_TYPE_NONE"
>> (initialize the iterator), but the assignment is redundant.
>>
>> I guess if the compiler optimizes it away anyway, it may be good for
>> readability, especially since it's an example. *shrug*
>
>
> I fail to see how the assignment is redundant?
> Without the assignment, that would be an infinite loop.

One assignment above...

Carl Eugen