[FFmpeg-devel] [FFmpeg-cvslog] lavd/alsa: Double maximum alsa buffer size.
Carl Eugen Hoyos
ceffmpeg at gmail.com
Tue Nov 28 00:55:29 EET 2017
2017-11-27 16:29 GMT+01:00 Nicolas George <george at nsup.org>:
> Carl Eugen Hoyos (2017-11-27):
>> ffmpeg | branch: master | Carl Eugen Hoyos <ceffmpeg at gmail.com> | Mon Nov 27 14:05:28 2017 +0100| [b7324950c0fc84a93d4e7abdfd2b75ea647ec3fc] | committer: Carl Eugen Hoyos
>> lavd/alsa: Double maximum alsa buffer size.
>> Fixes recording from ATI Wonder 600 USB adapter, regression since e35c674d.
> Why was this pushed without discussion?
>> Reported and analyzed by: Marco Paolieri, paolieri at gmail
> This is no analyze, just empirical guesswork.
The patch that introduced the regression was not discussed and
it used a guessed limit afair.
The patch that fixed ticket #373 simply doubled the value to fix
a particular use-case.
After this patch that follows this logic, the possible allocation
is still a magnitude smaller than the original commit claims.
(I cannot test the failing case.)
Do you want me to revert?
Any better suggestions?
Thank you, Carl Eugen
More information about the ffmpeg-devel