[FFmpeg-devel] [PATCH 3/8] avcodec/flac: add SSE4.2 version of the 32-bit lpc encoder

[James Almer]

On 11/26/2017 8:07 PM, Carl Eugen Hoyos wrote:
> 2017-11-26 23:51 GMT+01:00 James Darnley <james.darnley at gmail.com>:
> 
>> +    if (EXTERNAL_SSE42(cpu_flags)) {
>> +        if (CONFIG_GPL)
>> +            c->lpc32_encode = ff_flac_enc_lpc_32_sse42;
>> +    }
> 
> Any objections over "if (CONFIG_GPL && EXTERNAL_..)"?
> 
> Carl Eugen

I prefer it as is. It's not only similar to other checks around it, but
also if someone decides to write an lgpl sse4.2 function they will not
have to change the existing statement or add a duplicate one.