[FFmpeg-devel] [PATCH] hls demuxer: add option to defer parsing of variants

Rainer Hochecker rainer.hochecker at googlemail.com
Sun Nov 26 13:16:13 EET 2017


2017-11-26 12:04 GMT+01:00 Steven Liu <lingjiujianke at gmail.com>:
> 2017-11-26 18:46 GMT+08:00 Rainer Hochecker <fernetmenta at online.de>:
>> fixed mem leak poined out by Steven
> Hi Rainer,
>
>     I'm not sure that is memleak, but looks like memleak when reading
> the code, i see the code always in hls.c before this patch, but no
> people report it memleak.
>     If that is memleak, maybe use goto method is better way, because
> the workflow of bellow have alloc resource faild check, i will point
> out base on your patch.
>>

Hi Steven,

As soon as you associate the probe buffer with the context, the context cares
about allocated resources. That's most likely the reason why pb was not
cleared here. It is assigned to the context right after this block.

Rainer


More information about the ffmpeg-devel mailing list