[FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

[Michael Niedermayer]

On Thu, Nov 23, 2017 at 11:00:21PM +0100, Michael Niedermayer wrote:
> On Wed, Nov 22, 2017 at 11:59:30PM +0100, Hendrik Leppkes wrote:
> > On Wed, Nov 22, 2017 at 11:38 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > > 2017-11-22 21:00 GMT+01:00 Michael Niedermayer <michael at niedermayer.cc>:
> > >
> > >> diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c
> > >> index a0ef6859f1..0db932a105 100644
> > >> --- a/libavcodec/sbrdsp_fixed.c
> > >> +++ b/libavcodec/sbrdsp_fixed.c
> > >> @@ -133,7 +133,7 @@ static av_always_inline SoftFloat autocorr_calc(int64_t accu)
> > >>
> > >>          round = 1U << (nz-1);
> > >>          mant = (int)((accu + round) >> nz);
> > >> -        mant = (mant + 0x40)>>7;
> > >> +        mant = (mant + 0x40ll)>>7;
> > >
> > > LL?
> 
> I can change it to LL if preferred, i guess ill do that, LL seems more
> common in our source

and applied with LL


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171125/bc45aaa8/attachment.sig>