[FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

Tobias Rapp t.rapp at noa-archive.com
Fri Nov 24 09:51:47 EET 2017


On 23.11.2017 00:10, Derek Buitenhuis wrote:
> On 11/22/2017 10:52 PM, Carl Eugen Hoyos wrote:
>> start_line = fields * (i ^ (par->field_order == AV_FIELD_BB ||
>> par->field_order == AV_FIELD_BT));
>>
>> Which are imo less ugly.
> 
> Can't agree.
> 
> It's needlessly less readable bit fiddling.

+1

It may save some lines by in my opinion the current code is more 
readable and maintainable in case there are changes to AVFieldOrder (see 
discussion at 
https://ffmpeg.org/pipermail/ffmpeg-devel/2017-September/215698.html).

Regards,
Tobias



More information about the ffmpeg-devel mailing list