[FFmpeg-devel] [PATCH] avfilter: slice processing for geq

Marc-Antoine ARNAUD arnaud.marcantoine at gmail.com
Wed Nov 22 16:38:30 EET 2017


It made sense, but this commit don't touch this part of the code.
It can made more sense to add an another path to "prevent bad memory
allocation in geq filter". What do you think ?

Regards,

Le mer. 22 nov. 2017 à 15:19, Derek Buitenhuis <derek.buitenhuis at gmail.com>
a écrit :

> On 11/22/2017 10:24 AM, Marc-Antoine ARNAUD wrote:
> > New patch version which fixe the last remark.
>
> [...]
>
> > +        char depth_string[8];
> > +        snprintf(depth_string, sizeof(depth_string), "%d",
> (1<<geq->depth) - 1);
> > +        geq->expr_str[A] = av_strdup(depth_string);
>
> Missing return value check for av_strdup.
>
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list