[FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Added configuration to override HTTP User-Agent

Jeyapal, Karthick kjeyapal at akamai.com
Mon Nov 20 13:31:30 EET 2017


>On 11/20/17, 1:47 PM, "刘歧" <lq at chinaffmpeg.org> wrote:


>> 在 2017年11月20日,15:59,Jeyapal, Karthick <kjeyapal at akamai.com> 写道:
>> 
>>> On 11/20/17, 1:01 PM, "刘歧" <lq at chinaffmpeg.org> wrote:
>>>> 在 2017年11月8日,17:22,Karthick J <kjeyapal at akamai.com> 写道:
>>>> +    { "http_user_agent", "override User-Agent field in HTTP header", OFFSET(user_agent), AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, E},
>>> What about dash_user_agent? The reason is http_user_agent maybe get mean HTTP Protocol user_agent, but this is used in dashenc.
>> 
>> I kept http_user_agent to maintain uniformity with hlsenc option. 
>> http://ffmpeg.org/pipermail/ffmpeg-devel/2017-September/215642.html
>> 
>> In that way, irrespective of hls or dash output format, http_user_agent would apply for both.
>that should modify to hls_user_agent too. because that is clarified the option is used in dash or hls, isn’t it?

Sure. I am ok with dash_user_agent as well. 
I have attached a new patch with the option renamed to dash_user_agent.

Thanks and regards,
Karthick




-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avformat-dashenc-Added-configuration-to-override-HTT.patch
Type: application/octet-stream
Size: 5349 bytes
Desc: 0001-avformat-dashenc-Added-configuration-to-override-HTT.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171120/928ebc42/attachment.obj>


More information about the ffmpeg-devel mailing list