[FFmpeg-devel] [PATCH 6/8] x86inc: reduce difference to x264 upstream

[James Almer]

On 11/6/2017 5:28 PM, James Darnley wrote:
> On 2017-11-06 21:15, James Almer wrote:
>> On 11/6/2017 4:56 PM, James Darnley wrote:
>>> Line 733 is the align command to align the start of the function.  I
>>> can't see why it fails here but not on any other function in that file
>>> or any other file.
>>>
>>> After some cutting and pasting there is something about the mmxext
>>> function on line 159.  Cutting it out with the following diff, and
>>> building it will succeed.
>>>
>>>> ...
>>>
>>> I honestly have no idea why that causes a problem for the following
>>> function.  I thought it might be the lower-case ret rather than the
>>> upper-case RET macro but changing it doesn't change the error.
>>
>> Try compiling with
>>
>> make libavcodec/x86/rv34dsp.dbg.asm DBG=1
>> make libavcodec/x86/rv34dsp.dbg.o DBG=1
>>
>> To bypass all the macro obfuscation and get errors pointing to the exact
>> problematic line in the preprocessed .dbg.asm file
> 
> WTF?!  Both those lines run without error.

The first one is supposed to. It's just pre processes the asm file and
creates a new one. The second command should fail, though, assuming
assembling the normal libavcodec/x86/rv34dsp.o object also fails.