[FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

[James Almer]

On 11/6/2017 9:53 AM, Carl Eugen Hoyos wrote:
> 2017-11-06 5:40 GMT+01:00 Rostislav Pehlivanov <atomnuker at gmail.com>:
> 
>>> +    {
>>> +        .id        = AV_CODEC_ID_SBC,
>>> +        .type      = AVMEDIA_TYPE_AUDIO,
>>> +        .name      = "sbc",
>>> +        .long_name = NULL_IF_CONFIG_SMALL("SBC (low-complexity subband
>>> codec)"),
>>> +    },
>>> +    {
>>> +        .id        = AV_CODEC_ID_MSBC,
>>> +        .type      = AVMEDIA_TYPE_AUDIO,
>>> +        .name      = "msbc",
>>> +        .long_name = NULL_IF_CONFIG_SMALL("mSBC (wideband speech mono
>>> SBC)"),
>>> +    },
>>>
>>
>> Is there a bitstream difference between the two? I don't think so, so you
>> should instead define FF_PROFILE_SBC_WB and use a single codec ID.
> 
> Would that have an advantage?
> 
> One day, somebody will it into isom and define two different codec_tags...

DTS audio has a lot of different codec tags in isom, including DTS-E
which is a completely different bitstream altogether, and we have a
single codec ID for them all.

The de/muxer can handle it just fine, so it's not an issue.

> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>