[FFmpeg-devel] [PATCH]lavc/pcm-bluray: Do not use incompatible pointers on big-endian.

[Hendrik Leppkes]

On Wed, Nov 1, 2017 at 5:16 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> Hi!
>
> Attached patch silences two gcc warnings, no sample for odd channel count found.
>
>  #if HAVE_BIGENDIAN
> -                    bytestream2_get_buffer(&gb, dst16, avctx->channels * 2);
> -                    dst16 += avctx->channels;
> +                    uint8_t *dst = frame->data[0];
> +                    bytestream2_get_buffer(&gb, frame->data[0], avctx->channels * 2);
> +                    dst += avctx->channels * 2;
>  #else
>                      channel = avctx->channels;
>                      do {

This hunk seems fishy. dst is only ever set, never read, and this code
is executed in a loop but always writes to the same position.

- Hendrik