[FFmpeg-devel] [PATCH] avfilter: align data frame when needed

Muhammad Faiz mfcc64 at gmail.com
Wed May 17 09:37:42 EEST 2017


On Wed, May 17, 2017 at 10:47 AM, James Almer <jamrial at gmail.com> wrote:
> On 5/16/2017 11:28 PM, Ronald S. Bultje wrote:
>> Hi,
>>
>> On Tue, May 16, 2017 at 7:43 PM, Muhammad Faiz <mfcc64 at gmail.com> wrote:
>>
>>> On Wed, May 17, 2017 at 6:33 AM, Ronald S. Bultje <rsbultje at gmail.com>
>>> wrote:
>>>> Hi,
>>>>
>>>> On Tue, May 16, 2017 at 7:23 PM, Muhammad Faiz <mfcc64 at gmail.com> wrote:
>>>>
>>>>> On Sun, May 7, 2017 at 8:18 PM, Nicolas George <george at nsup.org> wrote:
>>>>>> L'octidi 18 floréal, an CCXXV, James Almer a écrit :
>>>>>>> Will that complete fix be ready and be backport-enabled (AKA, no new
>>>>>>> API) in the coming days?
>>>>>>
>>>>>> It can. Right now, I am waiting for a comment from Hendrik, who seemed
>>>>>> to have objections on the principle but that I hope to have convinced.
>>>>>> After that, the coding is quite straightforward.
>>>>>
>>>>> I will push soon if there is no progress in that complete fix.
>>>>
>>>>
>>>> Push what patch exactly?
>>>
>>> Push my patch (avfilter: align data frame when needed).
>>
>>
>> Wasn't consensus that you should backport the new API, possibly with ff
>> prefix, and call it in relevant places, to make sure that the code in new
>> and old branch is identical?
>>
>> Ronald
>
> Yes, but as he said, if there's no progress in that complete fix, then
> this partial fix should be pushed instead, at least for one point
> release in the 3.3 branch before being replaced.
> For that matter, it should have happened for 3.3.1, seeing the complete
> fix couldn't be done in time even though it was supposed to.

Actually, one can argue that because we've already missed 3.3.1, we
should wait for 3.3.2. But I can argue that master branch also has
users, and keeping the crash unresolved at master branch is not good
idea at all.

Thank's.


More information about the ffmpeg-devel mailing list