[FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_check_align().

Michael Niedermayer michael at niedermayer.cc
Sun May 14 20:51:21 EEST 2017


On Sun, May 14, 2017 at 12:07:59PM +0200, Nicolas George wrote:
> Le duodi 22 floréal, an CCXXV, Michael Niedermayer a écrit :
> > The direct value like 32 feels more natural to me too, but iam fine
> > with either.
> > 
> > The avoidance of log() might also favor the other in some cases btw
> > consider you have a 32 and need to call a fuction that needs a log2(32)
> 
> So, shall I push? With the current code or without the 1<<?

I am fine with and withhout 1<<. direct numbers seem more consistent
to existing API like FFALIGN.
It seems though theres still open questions or objections IIUC
so i suspect this will more likely be in 3.3.2 ...

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170514/97d459b2/attachment.sig>


More information about the ffmpeg-devel mailing list