[FFmpeg-devel] [PATCH V2] lavc/vaapi_encode_h264: Enable MB rate control

[Michael Niedermayer]

On Fri, May 12, 2017 at 02:27:45PM +0800, Jun Zhao wrote:
> V2: - Refine the name/value type to mb_rate_control/bool.
>     - Only supported GEN9+ (SKL/APL/KBL/...)
>     - i965 driver default use frame-level rate control algorithm (generate the QP for each frame), 
>       when enable mb_rate_control, it's will enable the MB-level RC algorithm (generate the QP for each MB). 
>     - enables MB-level bitrate control that generally improves subjective visual quality, 
>       but have negative impact on performance and objective visual quality metric. 

>  vaapi_encode_h264.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> c835733e8022f49f94585253793fb6712509d1cb  0001-lavc-vaapi_encode_h264-Enable-MB-rate-control.patch
> From 9223a87e48c846f1ab7c65ba857d902de70349a8 Mon Sep 17 00:00:00 2001
> From: Jun Zhao <jun.zhao at intel.com>
> Date: Tue, 9 May 2017 08:19:16 +0800
> Subject: [PATCH V2] lavc/vaapi_encode_h264: Enable MB rate control.
> 
> Enables macroblock-level bitrate control that generally improves
> subjective visual quality. It may have a negative impact on
> performance and objective visual quality metrics. Default is off
> and can't compatible with Constant QP.
> 
> Signed-off-by: Jun Zhao <jun.zhao at intel.com>
> ---
>  libavcodec/vaapi_encode_h264.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Fails to build
libavcodec/vaapi_encode_h264.c: In function ‘vaapi_encode_h264_configure’:
libavcodec/vaapi_encode_h264.c:1137:40: error: ‘struct <anonymous>’ has no member named ‘mb_rate_control’
         ctx->rc_params.rc.rc_flags.bits.mb_rate_control = opt->mb_rate_control;
                                        ^
make: *** [libavcodec/vaapi_encode_h264.o] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170512/6f626ff6/attachment.sig>