[FFmpeg-devel] [PATCH] avformat/matroskadec: fix resource leak

Hendrik Leppkes h.leppkes at gmail.com
Fri May 5 14:59:26 EEST 2017


On Fri, May 5, 2017 at 9:54 PM, Steven Liu <lq at chinaffmpeg.org> wrote:
> Fixes Coverity CID: 1405453
>
> Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
> ---
>  libavformat/matroskadec.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
> index 9e2c9bd..5282ef7 100644
> --- a/libavformat/matroskadec.c
> +++ b/libavformat/matroskadec.c
> @@ -3893,6 +3893,7 @@ static int webm_dash_manifest_cues(AVFormatContext *s, int64_t init_range)
>                             "%" PRId64, s->streams[0]->index_entries[i].timestamp);
>          if (ret <= 0 || (ret == 20 && i ==  s->streams[0]->nb_index_entries - 1)) {
>              av_log(s, AV_LOG_ERROR, "timestamp too long.\n");
> +                       av_free(buf);
>              return AVERROR_INVALIDDATA;
>          }
>          end += ret;

The change overall seems fine, but whats with the alignment? :)

- Hendrik


More information about the ffmpeg-devel mailing list