[FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

[Clément Bœsch]

On Mon, Mar 27, 2017 at 10:00:09AM +0200, Carl Eugen Hoyos wrote:
> 2017-03-27 9:51 GMT+02:00 Clément Bœsch <u at pkh.me>:
> > ---
> >  libavcodec/avcodec.h | 5 +++++
> >  libavcodec/version.h | 3 +++
> >  2 files changed, 8 insertions(+)
> >
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index 4f3303366f..5c891b531a 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -5667,6 +5667,7 @@ attribute_deprecated
> >  void avcodec_set_dimensions(AVCodecContext *s, int width, int height);
> >  #endif
> >
> > +#if FF_API_TAG_STRING
> >  /**
> >   * Put a string representing the codec tag codec_tag in buf.
> >   *
> > @@ -5675,8 +5676,12 @@ void avcodec_set_dimensions(AVCodecContext *s, int width, int height);
> >   * @param codec_tag codec tag to assign
> >   * @return the length of the string that would have been generated if
> >   * enough space had been available, excluding the trailing null
> > + *
> > + * @deprecated see av_fourcc_make_string() and av_4cc2str().
> >   */
> > +attribute_deprecated
> >  size_t av_get_codec_tag_string(char *buf, size_t buf_size, unsigned int codec_tag);
> > +#endif
> 
> Sorry if I missed it:
> Please explain what the problem is with the current code.
> 

I can't make av_4cc2str() with that prototype. I take the opportunity to
move it to lavu since fourcc are related to format and codecs.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170327/1473aac0/attachment.sig>