[FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

Michael Niedermayer michael at niedermayer.cc
Mon Mar 13 05:21:52 EET 2017


On Sun, Mar 12, 2017 at 08:54:07PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Sun, Mar 12, 2017 at 7:32 PM, James Almer <jamrial at gmail.com> wrote:
> 
> > On 3/12/2017 6:16 PM, Michael Niedermayer wrote:
> > > Using the same type across platforms is more robust and avoids platform
> > > specific issues from differences in range.
> > > Also fixed point integers are on a semantical level not size_t
> > >
> > > Previous version reviewed-by: James Almer <jamrial at gmail.com>
> > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > > ---
> > >  ffprobe.c             |  2 +-
> > >  libavformat/dump.c    |  6 +++---
> > >  libavutil/spherical.c |  6 +++---
> > >  libavutil/spherical.h | 16 ++++++++--------
> > >  4 files changed, 15 insertions(+), 15 deletions(-)
> >
> > Needs FATE update.
> 
> 
> Since this is Vittorio's code, it's probably good to ask him [CC]? From

yes,

semi on topic: but i think people interrested in FFmpeg
development and the direction the code goes should subscribe to
ffmpeg-devel. This CC-ing is not too practical

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170313/0a239630/attachment.sig>


More information about the ffmpeg-devel mailing list