[FFmpeg-devel] [PATCH 1/5 v3] movenc: use correct tag list for AVOutputFormat.codec_tag

[James Almer]

On 6/29/2017 5:51 PM, Michael Niedermayer wrote:
> On Thu, Jun 29, 2017 at 03:52:05PM +0100, Derek Buitenhuis wrote:
>> From: John Stebbins <stebbins at jetheaddev.com>
>>
>> ff_mp4_obj_type contains the wrong type of tags for
>> AVOutputFormat.codec_tag. AVOutputFormat.codec_tag is used to
>> validate AVCodecParameters.codec_tag so needs to be the same
>> type of tag.
>>
>> Creates new tag lists for mp4 and ismv.  New tag lists support
>> same list of codecs found in ff_mp4_obj_type. psp uses the same
>> tag list as mp4 since these both use mp4_get_codec_tag to look up tags.
>>
>> (cherry picked from commit 713efb2c0d013a42be4051adb7cd90a7c2cbbb4f)
>> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
>> ---
>> With fixed EVRC.
>> ---
>>  libavformat/movenc.c | 42 +++++++++++++++++++++++++++++++++++++++---
>>  1 file changed, 39 insertions(+), 3 deletions(-)
> 
> this seems to break:
> ./ffmpeg -i matrixbench_mpeg2.mpg -f dash file-fdash.dash
> 
> [mp4 @ 0x42b6040] Tag [33][0][0][0] incompatible with output codec id '28' (avc1)
> Could not write header for output file #0 (incorrect codec parameters ?): Invalid data found when processing input
> Error initializing output stream 0:0 --

dashenc is also using ff_mp4_obj_type. Guess it should be a matter of
changing that as well. It would require making the new codec_mp4_tags[]
shared in isom.c