[FFmpeg-devel] [PATCH] x86inc: don't use read-only data sections on COFF targets

[Clément Bœsch]

On Mon, Jun 26, 2017 at 12:32:15AM -0300, James Almer wrote:
> Yasm:
> src/libavfilter/x86/af_volume.asm:24: warning: Standard COFF does not support read-only data sections
> src/libavfilter/x86/af_volume.asm:24: warning: Unrecognized qualifier `align'
> 
> Nasm:
> src/libavfilter/x86/af_volume.asm:24: error: standard COFF does not support section alignment specification
> src/libavutil/x86/x86inc.asm:92: ... from macro `SECTION_RODATA' defined here
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> Untested.
> 
>  libavutil/x86/x86inc.asm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm
> index fa826e6d85..c4ec29bd9d 100644
> --- a/libavutil/x86/x86inc.asm
> +++ b/libavutil/x86/x86inc.asm
> @@ -88,6 +88,8 @@
>  %macro SECTION_RODATA 0-1 16
>      %ifidn __OUTPUT_FORMAT__,aout
>          section .text
> +    %elifidn __OUTPUT_FORMAT__,coff
> +        section .text
>      %else
>          SECTION .rodata align=%1
>      %endif


I can confirm it fixes the compilation on DJGPP FATE instance.

Side note: I just noticed the object dependencies are broken with nasm
(typically, x86inc.asm is not present in libavfilter/x86/af_volume.d).

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170627/77694d63/attachment.sig>