[FFmpeg-devel] [PATCH] Add FITS Decoder

Paras Chadha paraschadha18 at gmail.com
Fri Jun 9 20:11:19 EEST 2017


On Fri, Jun 9, 2017 at 1:26 AM, Moritz Barsnick <barsnick at gmx.net> wrote:

> On Thu, Jun 08, 2017 at 22:34:15 +0530, Paras Chadha wrote:
> > +            t64 = (((uint64_t) ptr8[0]) << 56) | (((uint64_t) ptr8[1])
> << 48) | (((uint64_t) ptr8[2]) << 40) | (((uint64_t) ptr8[3]) << 32) |
> (ptr8[4] << 24) | (ptr8[5] << 16) | (ptr8[6] << 8) | ptr8[7];
>
> I think you can (or should?) use macros such as av_be2ne64() for this,
> and all the other shift-byte-placements throughout the code. (Yes, I
> know that operation is doing "ne2be", but there's no macro for that,
> probably because it's identical.) In addition to being shorter, they
> will evaluate to pure assignments on big-endian platforms.


yes, Done


More information about the ffmpeg-devel mailing list