[FFmpeg-devel] [PATCH 6/7] lavfi/framesync2: implement activate design.

Paul B Mahol onemda at gmail.com
Tue Jul 18 17:30:48 EEST 2017


On 7/18/17, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> On 7/17/2017 3:19 PM, Nicolas George wrote:
>> Signed-off-by: Nicolas George <george at nsup.org>
>> ---
>>  libavfilter/framesync2.c | 166
>> +++++++++++++++++++----------------------------
>>  libavfilter/framesync2.h |  77 ++++------------------
>>  2 files changed, 82 insertions(+), 161 deletions(-)
>
> So what does this patch set *do*? The commit message has literally no
> information on what this actually does. One can say "well go read the
> entirety of the mailing list backlog", but that sure isn't a very good
> way to help e.g. people who git blame in the future. There is no
> substitute for a commit message.
>
> Also 'activate design' is gibberish in English, which doesn't help
> letting one know what it does.

I actually like this 'design', as its more like VS one.


More information about the ffmpeg-devel mailing list