[FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

Dale Curtis dalecurtis at chromium.org
Tue Jul 18 03:54:26 EEST 2017


Okay the following patch should fix this issue. Chromium/reviewable version
here https://chromium-review.googlesource.com/c/572585/

- dale

On Fri, Jul 14, 2017 at 6:31 PM, Dale Curtis <dalecurtis at chromium.org>
wrote:

> On Fri, Jul 14, 2017 at 5:38 PM, Michael Niedermayer <
> michael at niedermayer.cc> wrote:
>
>>
>> I dont think CTTS is the only affected atom.
>>
>>
> Thanks for the response. Yes, I think that's likely true. The ctts one is
> just likely the most important since it controls timestamp ordering.
>
>
>> what you describe sounds like an option. but i might be missing something,
>> possibly even something significant. I dont feel that confident with
>> this code after quickly looking at it.
>>
>
> Here are my experiments thus far if you have further thoughts:
> https://chromium-review.googlesource.com/c/572730/
> https://chromium-review.googlesource.com/c/572585/
>
> Both fixes and the existing code seem to suffer from assuming that the
> sample number in the AVIndex and that of the ctts_data are the same; which
> seems questionable. The second experiment should be viable with the
> addition of memmove() when inserting in the middle of the array. Will look
> at it more next week.
>
> - dale
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-trampling-of-ctts-during-seeks-when-sidx-support.patch
Type: text/x-patch
Size: 7173 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170717/c1023197/attachment.bin>


More information about the ffmpeg-devel mailing list