[FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

[Michael Niedermayer]

On Fri, Jul 14, 2017 at 10:55:56AM +0000, Kieran Kunhya wrote:
> On Thu, 13 Jul 2017 at 23:06 Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > On Wed, Jul 12, 2017 at 01:54:28PM +0000, Kieran Kunhya wrote:
> > > >
> > > > I actually would request a short note explaining the SUINTFLOAT type
> > usage.
> > > > Something like:
> > > > +typedef unsigned            SUINTFLOAT; // Equivalent to INTFLOAT,
> > > > Used as temporal cast to avoid undefined sign overflow operations.
> > > >
> > > > Maybe add such note to all "signed value in unsigned type" typedefs.
> > > >
> > >
> > > Needs to be in main documentation because nobody is going to understand
> > > this in 50 years time when mailing lists have bitrotted.
> >
> > ill post a patch that adds this as a doxygen comment in the patch,
> > that way it should be in the doxygen documentation
> >
> > if you meant it to be put some other place clarify where
> 
> 
> I mean full documentation of the thought process behind all these changes
> in doc/.
> Just like James spent weeks trying to fix the undocumented IDCTs from 15
> years ago, someone will probably end up struggling to understand this SUINT
> stuff in 20 years time.

you are correct. Most code is undocumented, its never good.

Ill post a patch that adds some docs for undefined / suint.



> 
> 
> > --
> > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > Modern terrorism, a quick summary: Need oil, start war with country that
> > has oil, kill hundread thousand in war. Let country fall into chaos,
> > be surprised about raise of fundamantalists. Drop more bombs, kill more
> > people, be surprised about them taking revenge and drop even more bombs
> > and strip your own citizens of their rights and freedoms. to be continued
> 
> 
> What relevance do your political views have on this mailing list about
> FFmpeg?

<off topic>

Its just a automatically generated email signature

for this specific one here, i think terrorism is a major problem the
world faces
Not so much because of terrorists or their victims but because of
what is being done by law makers and governments to counter terrorism.
(just think about it, if you wanted to do a terror attack would any of
 the new anti terror laws prevent you from doing it ?)
The terrorists are a negligbible point in human mortality statistics,
you are more likely to become president than being killed in an attack.
the freedoms everyone looses from the laws are a big part of the
damage the terrorists have achieved. Thats besides fear and innocent
lifes.

IMO terrorism is self limiting, the attacker dies, give him a darwin
award if you must, but not what he wants to achieve.

You can disagree 100% about everything. In fact i might myself have a
somewhat different oppinion in a few years. But just having people
think about this whole subject logically is a step towards a solution.

I was not sure anyone reads these silly signatures at all, or cares
about them.

</off topic>

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170715/89e7ded3/attachment.sig>